Open
Conversation
hatgit
added a commit
to hatgit/hatnotation
that referenced
this pull request
May 13, 2019
adding this PR hatgit/BIP39-Mnemonic-Tools#13 by #johhonn to this repo on a new dev branch so that I can run tests prior to committing to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the base64 encoder to use the initial entropy with the checksum which fixed the padding errors. I also added logic so that the decoder would also accept entropy encoded without the checksum. I also added logic that ensures the generated entropy is able to be encoded accurately in base 64. When it fails to generate the base 64 properly a new entropy string is simply generated.